Board3

Hello,

The names of the styles selected to display Font Awesome icons are not encoded in UTF-8 in the board3_portal_fa_styles config. When they contain special characters, they are not recognised and continue to display image icons.

Proposed fix — apply the following minimal change in the store_fa_styles() method to accept special characters:

Code: Select all

	public function store_fa_styles(string $key): void
	{
		$style_array = $this->request->variable($key, [''], true);
		$this->config->set('board3_portal_fa_styles', json_encode($style_array));
	}

In the longer term, might it be preferable to store the style IDs rather than their names?

Hi
Do you have an example of the special characters?

https://www.phpbb.com/customise/db/style/dama%C3%AFo/

I didn't understand why, even though I selected this style from the list, it didn't display the FA icons.
And I realised that it didn't appear as selected because it is stored as dama??o in the config.

You were right about special characters in a style.
The selection works with the changes you suggested in modules_helper.php.
Thank you for letting us know.

Board3

FA icons are not displayed on styles whose names contain special characters.

FA icons are not displayed on styles whose names contain special characters.

Re: FA icons are not displayed on styles whose names contain special characters.

Re: FA icons are not displayed on styles whose names contain special characters.

Re: FA icons are not displayed on styles whose names contain special characters.